Card branch #194
Merged
Card branch #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 29, 2024 15:29
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const parts = path.split('.') | ||
| parts.pop() | ||
| path = parts.join('.') | ||
| res.redirect(path) |
Check warning
Code scanning / CodeQL
Server-side URL redirect Medium
Comment on lines
94
to
+102
| app.get('/downloads/:filename', (req, res) => { | ||
| const filename = req.params.filename; | ||
| const filePath = path.join(__dirname, '/app/assets/downloads/' + filename); | ||
| const filename = req.params.filename | ||
| const filePath = path.join(__dirname, '/app/assets/downloads/' + filename) | ||
| // Set appropriate headers | ||
| // res.setHeader('Content-Type', 'application/vnd.openxmlformats-officedocument.wordprocessingml.document'); | ||
| res.setHeader('Content-Disposition', `attachment; filename=${filename}`); | ||
| res.setHeader('Content-Disposition', `attachment; filename=${filename}`) | ||
| // Send the file | ||
| res.sendFile(filePath); | ||
| }); | ||
| res.sendFile(filePath) | ||
| }) |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| // Send the file | ||
| res.sendFile(filePath); | ||
| }); | ||
| res.sendFile(filePath) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mergin in the card component changes to main, along with bug fixes, broken anchor links and other fixes.